Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build & provide multi-arch image #25

Merged
merged 15 commits into from
Aug 17, 2019

Conversation

bastilimbach
Copy link
Owner

@bastilimbach bastilimbach commented Aug 17, 2019

Closes #21
Closes #19
Closes #13

ToDo:

  • Create workflow for GitHub action (Replaces Travis CI) Will use Travis for now as the docker implementation for GitHub actions is kind of bad.
  • Create manifest for multi-arch docker image

@bastilimbach bastilimbach merged commit fc15216 into master Aug 17, 2019
@bastilimbach bastilimbach deleted the migrate-to-github-actions branch August 17, 2019 23:18
@bastilimbach bastilimbach mentioned this pull request Aug 17, 2019
@Legion2
Copy link
Contributor

Legion2 commented Jul 1, 2020

@bastilimbach what was the problem with GitHub Actions? Why didn't you used it in the end?

@bastilimbach
Copy link
Owner Author

@Legion2 “Will use Travis for now as the docker implementation for GitHub actions is kind of bad.“ This was before the new GitHub Actions. I tried to switch as this was in beta.

I might consider moving to the new GitHub actions now. They look really promising and so much easier with the new yaml syntax.

I‘m just not internally sure if I can schedule them using cron 🤔

@Legion2
Copy link
Contributor

Legion2 commented Jul 1, 2020

you can schedule GitHub Actions with cron

@bastilimbach
Copy link
Owner Author

Then maybe I should take another look at GitHub actions!

@bastilimbach
Copy link
Owner Author

@Legion2 I created issue #43. Are you familiar with the GitHub actions syntax? Maybe you could help here :)

@Legion2
Copy link
Contributor

Legion2 commented Jul 5, 2020

Yes I already have created many GitHub Actions workflows and also migrated some from Travis. I can provide a PR if you want maybe next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker mm update Module directory checking and updating
2 participants